fix: resolve issue with prev-grapheme-cluster-break function #1431
Conversation
|
@kgryte , @Pranavchiku, @Planeshifter Please check the integrity of this PR, and send reviews |
| // Get the corresponding grapheme break and emoji properties: | ||
| breaks.push( breakProperty( cp ) ); | ||
| emoji.push( emojiProperty( cp ) ); | ||
| if (!(cp >= 0x1F3FB && cp <= 0x1F3FF)) { // Check if the character is not a skin tone modifier |
There was a problem hiding this comment.
This is too narrow a patch. It is not just skin tones, TMK, but any modifier. The implementation more generally should be refactored to ensure that grapheme clusters comprised of multiple code points are handled correctly.
There was a problem hiding this comment.
Oh I am sorry, I got confused by seeing the original issue being raised about the colour tone.
I will try to debug and propose a generic solution to this as soon as possible.
Thank You.
| // Get the corresponding grapheme break and emoji properties: | ||
| breaks.push( breakProperty( cp ) ); | ||
| emoji.push( emojiProperty( cp ) ); | ||
| if (!(cp >= 0x1F3FB && cp <= 0x1F3FF)) { // Check if the character is not a skin tone modifier |
kgryte
added
the
Needs Changes
kgryte
added
Needs Changes
Planeshifter
added
the
Potential Duplicate
kgryte
added
the
autoclose: Stale
|
This pull request has been automatically closed because it has been inactive for an extended period after changes were requested. If you still wish to pursue this contribution, feel free to reopen the pull request or submit a new one. We appreciate your interest in contributing to stdlib! |
4 participants
Resolves #1092 .
Description
There's an issue with prevGraphemeClusterBreak package, if I compare the results with nextGraphemeClusterBreak for a single skin tone emoji it doesn't return the same values,
Related Issues
This pull request:
prevGraphemeClusterBreakpackage #1092Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers